Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only normalize data in public shares and not crud #33941

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Only normalize data in public shares and not crud #33941

merged 1 commit into from
Sep 15, 2022

Conversation

CarlSchwan
Copy link
Member

No description provided.

@CarlSchwan CarlSchwan added the bug label Sep 7, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 7, 2022
@CarlSchwan CarlSchwan requested review from artonge and a team September 7, 2022 11:53
@CarlSchwan CarlSchwan self-assigned this Sep 7, 2022
@CarlSchwan CarlSchwan requested review from PVince81, blizzz and come-nc and removed request for a team September 7, 2022 11:53
artonge
artonge reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense

I can't find any occurrence of publicUpload in our code base, maybe we should deprecate it someday.

@blizzz blizzz mentioned this pull request Sep 7, 2022
Merged
@blizzz
Copy link
Member

blizzz commented Sep 8, 2022

@CarlSchwan integration-sharing-v1 failed

@CarlSchwan
Only normalize data in public shares and not crud
7ded5a7 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@blizzz blizzz mentioned this pull request Sep 9, 2022
Merged
PVince81
PVince81 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

@CarlSchwan please double check the failing sharing tests to see if related

@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@CarlSchwan
Copy link
Member Author

@CarlSchwan please double check the failing sharing tests to see if related

Tests work locally, so this seems to be a race condition as I saw the share link acceptance tests fail in other PR recently (probably caused by the redesign)

@CarlSchwan CarlSchwan merged commit 02d55eb into master Sep 15, 2022
@CarlSchwan CarlSchwan deleted the fix/public-sharing branch September 15, 2022 14:43
@mejo-
Copy link
Member

mejo- commented Oct 26, 2022

@CarlSchwan are you ok with backporting this to stable24?

@PVince81
Copy link
Member

PVince81 commented Jan 2, 2023

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 2, 2023
Merged
@nickvergessen nickvergessen mentioned this pull request Jan 5, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@PVince81 PVince81 PVince81 approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@come-nc come-nc Awaiting requested review from come-nc

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@CarlSchwan CarlSchwan

Labels
bug
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
5 participants
@CarlSchwan @blizzz @PVince81 @mejo- @artonge